Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data type select in welcome tour #192

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Jul 25, 2022

Found while testing https://github.com/Caleydo/tdp_bi_bioinfodb/issues/1371

Related to datavisyn/tdp_core#754

Summary

  • Fixes the selector when selecting the data type in the Cell Score (Single).

grafik

@thinkh thinkh added type: bug Something isn't working release: patch PR merge results in a new patch version labels Jul 25, 2022
Copy link
Contributor

@dvvanessastoiber dvvanessastoiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my tests, thank you for the fix! 👍

@thinkh thinkh merged commit b242464 into thinkh/fix-ts-compile-errors Jul 25, 2022
@thinkh thinkh deleted the thinkh/fix-data-type-select-in-welcome-tour branch July 25, 2022 11:45
thinkh added a commit that referenced this pull request Jul 25, 2022
…ged` of ranking views (#191)

* Fix TS errors ranking views

The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725

* Fix data type select in welcome tour (#192)
ghost pushed a commit that referenced this pull request Aug 4, 2022
* Pass drug screen when multiple data types are selected

* Clean up code

* Add additional depletion screen scores

Caleydo/tdp_bi_bioinfodb#1364

* orphan import

* Linting and other fixes

* Linting

* prepare next development version 12.0.1-SNAPSHOT

* Replace `gene_map_ensgs` with idtype mapping

Closes Caleydo/tdp_bi_bioinfodb#419

* Replace `gene_map_ensgs` request with native idtype mapping
* Remove python DB view
* Remove `_id` from typing, as it was not returned by the API and was not used previously

* Remove orphan import

* Fix typo in depletion screen score name

* Allow for the domain of the scores to be auto-inferred (#175)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191)

* Fix TS errors ranking views

The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725

* Fix data type select in welcome tour (#192)

* Fix outdated dist folder (#194)

* Prepare github changes

* Remove circleci

* prepare release 12.1.0

* Update publish.yml

Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: anita-steiner <>
Co-authored-by: Anita Steiner <anita.steiner@datavisyn.io>
ghost pushed a commit that referenced this pull request Sep 8, 2022
* Pass drug screen when multiple data types are selected

* Clean up code

* Add additional depletion screen scores

Caleydo/tdp_bi_bioinfodb#1364

* orphan import

* Linting and other fixes

* Linting

* prepare next development version 12.0.1-SNAPSHOT

* Replace `gene_map_ensgs` with idtype mapping

Closes Caleydo/tdp_bi_bioinfodb#419

* Replace `gene_map_ensgs` request with native idtype mapping
* Remove python DB view
* Remove `_id` from typing, as it was not returned by the API and was not used previously

* Remove orphan import

* Fix typo in depletion screen score name

* Allow for the domain of the scores to be auto-inferred (#175)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191)

* Fix TS errors ranking views

The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725

* Fix data type select in welcome tour (#192)

* Fix outdated dist folder (#194)

* Prepare github changes

* Remove circleci

* prepare next dev version

* Update fontawesome

* refactor: Improve Cypress setup and use Cypress commands.js (#169)

Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Merge visyn_scripts

* prepare release 13.0.0

Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: anita-steiner <>
Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
ghost pushed a commit that referenced this pull request Sep 30, 2022
* Pass drug screen when multiple data types are selected

* Clean up code

* Add additional depletion screen scores

Caleydo/tdp_bi_bioinfodb#1364

* orphan import

* Linting and other fixes

* Linting

* prepare next development version 12.0.1-SNAPSHOT

* Replace `gene_map_ensgs` with idtype mapping

Closes Caleydo/tdp_bi_bioinfodb#419

* Replace `gene_map_ensgs` request with native idtype mapping
* Remove python DB view
* Remove `_id` from typing, as it was not returned by the API and was not used previously

* Remove orphan import

* Fix typo in depletion screen score name

* Allow for the domain of the scores to be auto-inferred (#175)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191)

* Fix TS errors ranking views

The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725

* Fix data type select in welcome tour (#192)

* Fix outdated dist folder (#194)

* Prepare github changes

* Remove circleci

* prepare next dev version

* Update fontawesome

* refactor: Improve Cypress setup and use Cypress commands.js (#169)

Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Merge visyn_scripts

* prepare next dev version

* Add nowrap to button, add scrollbar to searchbox (#203)

* Show CoExpression messages / errors (#202)

* prepare release 13.0.1

* Fix sorting of chromosomes due to new typings (#206)

* Fix sorting of chromosomes due to new typings

Caused by datavisyn/tdp_core#794

* Add missing dist files

Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: anita-steiner <>
Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
dvvanessastoiber added a commit that referenced this pull request Nov 24, 2022
* Pass drug screen when multiple data types are selected

* Clean up code

* Add additional depletion screen scores

Caleydo/tdp_bi_bioinfodb#1364

* orphan import

* Linting and other fixes

* Linting

* prepare next development version 12.0.1-SNAPSHOT

* Replace `gene_map_ensgs` with idtype mapping

Closes Caleydo/tdp_bi_bioinfodb#419

* Replace `gene_map_ensgs` request with native idtype mapping
* Remove python DB view
* Remove `_id` from typing, as it was not returned by the API and was not used previously

* Remove orphan import

* Fix typo in depletion screen score name

* Allow for the domain of the scores to be auto-inferred (#175)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191)

* Fix TS errors ranking views

The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725

* Fix data type select in welcome tour (#192)

* Fix outdated dist folder (#194)

* Prepare github changes

* Remove circleci

* prepare next dev version

* Update fontawesome

* refactor: Improve Cypress setup and use Cypress commands.js (#169)

Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Merge visyn_scripts

* prepare next dev version

* Add nowrap to button, add scrollbar to searchbox (#203)

* Show CoExpression messages / errors (#202)

* Fix sorting of chromosomes due to new typings (#206)

* Fix sorting of chromosomes due to new typings

Caused by datavisyn/tdp_core#794

* Add missing dist files

* prepare next dev version

* Fix score domains (#204)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* fix: boxplot and matrix domain in aggregated scores (#208)

Fix boxplot and matrix domain in aggregated scores

Fixes Caleydo/tdp_bi_bioinfodb#1402

* fix: domain of gene signature scores (#209)

Caleydo/tdp_bi_bioinfodb#1402

* fix: rename AVANA to Avana

* prepare release 13.0.2

Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: anita-steiner <>
Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
dvvanessastoiber added a commit that referenced this pull request Dec 13, 2022
* Pass drug screen when multiple data types are selected

* Clean up code

* Add additional depletion screen scores

Caleydo/tdp_bi_bioinfodb#1364

* orphan import

* Linting and other fixes

* Linting

* prepare next development version 12.0.1-SNAPSHOT

* Replace `gene_map_ensgs` with idtype mapping

Closes Caleydo/tdp_bi_bioinfodb#419

* Replace `gene_map_ensgs` request with native idtype mapping
* Remove python DB view
* Remove `_id` from typing, as it was not returned by the API and was not used previously

* Remove orphan import

* Fix typo in depletion screen score name

* Allow for the domain of the scores to be auto-inferred (#175)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191)

* Fix TS errors ranking views

The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725

* Fix data type select in welcome tour (#192)

* Fix outdated dist folder (#194)

* Prepare github changes

* Remove circleci

* prepare next dev version

* Update fontawesome

* refactor: Improve Cypress setup and use Cypress commands.js (#169)

Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Merge visyn_scripts

* prepare next dev version

* Add nowrap to button, add scrollbar to searchbox (#203)

* Show CoExpression messages / errors (#202)

* Fix sorting of chromosomes due to new typings (#206)

* Fix sorting of chromosomes due to new typings

Caused by datavisyn/tdp_core#794

* Add missing dist files

* prepare next dev version

* Fix score domains (#204)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* fix: boxplot and matrix domain in aggregated scores (#208)

Fix boxplot and matrix domain in aggregated scores

Fixes Caleydo/tdp_bi_bioinfodb#1402

* fix: domain of gene signature scores (#209)

Caleydo/tdp_bi_bioinfodb#1402

* fix: rename AVANA to Avana

* prepare next dev version

* add: missing dist files

* prepare release 13.0.3

Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: anita-steiner <>
Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants